📚 docs: CONTRIBUTING.mdのprefixとブランチ名を修正 #171 #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
承知です！ ドラフト解除していただいたら、承認しますよ！👍 |
|
ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
CONTRIBUTING.mdのprefixの欄と、ブランチ名の欄を修正しました。
関連するIssue
closed #171
その他
コード改善は
♻️ refactorとする予定でしたが、improveの方が汎用性が高いのではと思い、一旦improveでドラフトプルリクとします。improveを提案する理由としては、「バグ修正」とも「リファクタリング」とも言えないコードの改善（例えば、無意味な空白の削除や、Prettierで取りこぼしたものなどの修正）も、improveだったら迷わずimproveに振り分けられるなと個人的に思ったからです。refactorだと、なんとなくコードの大幅改善のようなイメージがあるような……。どう思いますか？👀
参考
残課題