Skip to content

コミットメッセージでの絵文字の使い方を記載 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2024
Merged

コミットメッセージでの絵文字の使い方を記載 #50

merged 2 commits into from
Mar 17, 2024

Conversation

@kagomen
Copy link
Member

@kagomen kagomen commented Mar 17, 2024

概要

CONTRIBUTING.mdに、コミットメッセージでの絵文字の使い方を記載しました

関連するIssue

closed #38

@kazzyfrog kazzyfrog self-requested a review March 17, 2024 07:04
kazzyfrog
kazzyfrog reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@kazzyfrog kazzyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます🙌
下記１点だけ、意図をお伺いしたいです！

pss-aileen
pss-aileen reviewed Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@pss-aileen pss-aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様です！
1点だけご確認よろしくお願いいたします🙌

@pss-aileen pss-aileen mentioned this pull request Mar 17, 2024
Closed
@kagomen
Copy link
Member Author

kagomen commented Mar 17, 2024

内容変更しました。
また、ブランチのprefixの命名規則がコミットメッセージと内容がかぶっていたため、まとめました。
ご確認お願いします！

kazzyfrog
kazzyfrog approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@kazzyfrog kazzyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM😎

pss-aileen
pss-aileen reviewed Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@pss-aileen pss-aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🫰

pss-aileen
pss-aileen approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@pss-aileen pss-aileen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🫰Approve!

@kazzyfrog
Copy link
Member

@kagomen
よかったら、Squash mergeしてみてください！
このPRの２つのコミットを、１つにまとめられますよ👍

その際、コミットメッセージは、１つ目の📚 docs: コミットメッセージでの絵文字の使い方を記載 #38で良いと思います！

@pss-aileen pss-aileen merged commit ea703a9 into main Mar 17, 2024
@pss-aileen pss-aileen deleted the docs/#38_howToUseEmoji branch March 17, 2024 17:25
@pss-aileen
Copy link
Collaborator

@kazzyfrog
あ！あ！！！すみません！！！！！マージしてしまいました....！！！！！！！！

@pss-aileen
Copy link
Collaborator

次、のプルリクは kagome さんにしてもらいます！！！！

@kazzyfrog
Copy link
Member

あ、大丈夫ですw
またの機会で！！！👍

@kazzyfrog kazzyfrog added the Type: 📚 docs ドキュメント作成、追記に関するもの label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazzyfrog kazzyfrog kazzyfrog approved these changes

@pss-aileen pss-aileen pss-aileen approved these changes

Assignees

No one assigned

Labels

Type: 📚 docs ドキュメント作成、追記に関するもの

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.mdのコミットメッセージの内容を絵文字付きに修正する

4 participants

@kagomen @kazzyfrog @pss-aileen