Remote relay aggregator started even if secondary remote endpoints not configured

[ctRAC3r]

Builder (main branch) attempts to start the relay aggregator even if secondary relay endpoint(s) are not set:

INFO [12-03|19:17:59.193] requesting                               currentSlot=0
INFO [12-03|19:17:59.602] Updated validators                       count=54 slot=0
INFO [12-03|19:17:59.602] requesting                               currentSlot=0
ERROR[12-03|19:17:59.602] could not get validators map from relay, retrying err="Get \"/relay/v1/builder/validators\": unsupported protocol scheme \"\""
ERROR[12-03|19:18:00.603] could not get validators map from relay, retrying err="Get \"/relay/v1/builder/validators\": unsupported protocol scheme \"\""
ERROR[12-03|19:18:01.603] could not get validators map from relay, retrying err="Get \"/relay/v1/builder/validators\": unsupported protocol scheme \"\""
ERROR[12-03|19:18:02.605] could not get validators map from relay  err="Get \"/relay/v1/builder/validators\": unsupported protocol scheme \"\""
ERROR[12-03|19:18:02.605] could not connect to remote relay, continuing anyway err="Get \"/relay/v1/builder/validators\": unsupported protocol scheme \"\""

This happens because strings.Split returns a slice of length 1 with the original string ("") if it can't match the separator (","):

builder/cmd/utils/flags.go

Line 1590 in 5d25e8b

cfg.SecondaryRemoteRelayEndpoints = strings.Split(ctx.String(BuilderSecondaryRemoteRelayEndpoints.Name), ",")

Making the following change fixes the issue:

builder/builder/service.go

Line 163 in 5d25e8b

if len(cfg.SecondaryRemoteRelayEndpoints) > 0 {

-  if len(cfg.SecondaryRemoteRelayEndpoints) > 0 { 
+  if cfg.SecondaryRemoteRelayEndpoints[0] != "" {

[Ruteri]

Fixed in d8e0390

[Ruteri]

Thank you @ctRAC3r for raising the issue!