-
Notifications
You must be signed in to change notification settings - Fork 144
Bundle new UUID #112
Bundle new UUID #112
Conversation
634149e to
c6a8571
Compare
cd01ed3 to
2dc2e0e
Compare
b980a53 to
9777f52
Compare
| return buf | ||
| } | ||
|
|
||
| func (b *MevBundle) ComputeUUID() uuid.UUID { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking)
We should probably eventually use a sync.Once pattern to initialize the UUID once since we don't mutate bundles after initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought in a little bit different direction, I believe we'll eventually move to propagating this uuid as a field of bundle structure, but it'd be better be done once we have some module with shared models. But I anyway understand your concern, I hope we'll address it in future
|
looks great! Could you update your PR description with output successfully showing bundles inserted into database with the new schema and UUID? Otherwise lgtm, good stuff |
Done |
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
📝 Summary
Groundwork for using unique deterministic ID for bundles
Example of new inserted bundle from goerli (json extracted from db, stripped from irrelevant data):
📚 References
CONTRIBUTING.md