Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Add fix and update unit tests for header gas limit calculation #123

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Add fix and update unit tests for header gas limit calculation #123

merged 3 commits into from
Oct 4, 2023

Conversation

@Wazzymandias
Copy link
Contributor

📝 Summary

  • Update builder submission logic to calculate gas limit on payload attribute
  • Addresses long standing issue of blocks being rejected by relay on block validation due to invalid gas limit set on header
  • Tested with unit tests and on deployed service for several weeks to confirm the changes fix observed issue

📚 References

Ruteri
Ruteri approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wazzymandias Wazzymandias merged commit 45e865e into main Oct 4, 2023
@Wazzymandias Wazzymandias deleted the bugfix-builder-header-gas-limit branch October 4, 2023 20:59
estensen pushed a commit to estensen/builder that referenced this pull request Nov 16, 2023
@Ruteri @avalonche
Discard reverting megabundle blocks and head change interrupted blocks (
ed0d05b 
flashbots#123)

* Discard reverting megabundle blocks and head change interrupted blocks

* Discard all blocks with incomplete bundles

* Run reverting megabundles regression test separately from bundle tests
vazha pushed a commit to vazha/builder that referenced this pull request Feb 2, 2024
@Ruteri @avalonche
Discard reverting megabundle blocks and head change interrupted blocks (
9ef2ebc 
flashbots#123)

* Discard reverting megabundle blocks and head change interrupted blocks

* Discard all blocks with incomplete bundles

* Run reverting megabundles regression test separately from bundle tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@TymKh TymKh Awaiting requested review from TymKh TymKh is a code owner

@avalonche avalonche Awaiting requested review from avalonche avalonche is a code owner

1 more reviewer

@Ruteri Ruteri Ruteri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wazzymandias @Ruteri