This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Stop prefetcher in applyToBaseEnv() #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
approved these changes
Dec 27, 2022
Ruteri
approved these changes
Dec 28, 2022
|
I am very confident that this is the only place that matter. We create an The only problem that we have is if we swap The upside of this change is that it will not stop prefetcher if we don't use this method. (e.g. if we will have algorithm that works without state copying for bundles) |
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
* remove unused beacon client from the builder * build on multiple tips * worker async generateWork * rework bundle cache * fix validate payload test in main
avalonche
pushed a commit
that referenced
this pull request
Feb 7, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
* remove unused beacon client from the builder * build on multiple tips * worker async generateWork * rework bundle cache * fix validate payload test in main
avalonche
pushed a commit
that referenced
this pull request
Mar 9, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
* remove unused beacon client from the builder * build on multiple tips * worker async generateWork * rework bundle cache * fix validate payload test in main
avalonche
pushed a commit
that referenced
this pull request
Mar 15, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
* remove unused beacon client from the builder * build on multiple tips * worker async generateWork * rework bundle cache * fix validate payload test in main
avalonche
pushed a commit
that referenced
this pull request
Mar 17, 2023
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
* remove unused beacon client from the builder * build on multiple tips * worker async generateWork * rework bundle cache * fix validate payload test in main
avalonche
pushed a commit
that referenced
this pull request
Mar 22, 2023
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
* remove unused beacon client from the builder * build on multiple tips * worker async generateWork * rework bundle cache * fix validate payload test in main
avalonche
pushed a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Should fix #13
Its stops prefetcher when it can be leaked.