Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Prevent uint256 overflow during conversion #45

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Prevent uint256 overflow during conversion #45

merged 4 commits into from
Mar 13, 2023

Conversation

@avalonche
Copy link
Contributor

📝 Summary

📚 References

Ruteri
Ruteri reviewed Mar 10, 2023
View reviewed changes
michaelneuder pushed a commit to michaelneuder/builder that referenced this pull request Mar 10, 2023
@Ruteri @gelfand
@Code0x2 @ngotchac @Jolly23 @avalonche
Cleanup and include old mev geth prs (flashbots#45)
83a14be 
* Remove old infra scripts
* core: tx_pool not return `error` in `MevBundles()`
* Adjust worker to not consider error returned from MevBundles
* Update web3ext.go
* internal/ethapi: Fix context not being used
* fix: dev: add defer privateTx.Stop()

Co-authored-by: eugene <[email protected]>
Co-authored-by: 0x2 <[email protected]>
Co-authored-by: Nicolas Gotchac <[email protected]>
Co-authored-by: Jolly Zhao <[email protected]>
Ruteri
Ruteri reviewed Mar 10, 2023
View reviewed changes
Ruteri
Ruteri reviewed Mar 13, 2023
View reviewed changes
core/block_validator.go Outdated
}
// Withdrawals are present after the Shanghai fork.
if header.WithdrawalsHash != nil {
if v.config.IsShanghai(header.Time) {
Copy link
Collaborator

@Ruteri Ruteri Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this again, and I'd be wary of adding this check in this specific function, as it's not only used during boost relay block validation. We should simply make no changes in this function.
The function's logic should be exactly the same as upstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, the check should be in ValidatePayload until a check like this is included in the upstream.

@avalonche avalonche merged commit 2b0eaf2 into capella Mar 13, 2023
avalonche added a commit that referenced this pull request Mar 13, 2023
@avalonche
Prevent uint256 overflow during conversion (#45)
f061a3b 
* Prevent uint256 overflow during conversion

* add shanghai checks

* remove unused functions

* move validation to ValidatePayload
michaelneuder pushed a commit to michaelneuder/builder that referenced this pull request Mar 15, 2023
@Ruteri @gelfand
@Code0x2 @ngotchac @Jolly23 @avalonche
Cleanup and include old mev geth prs (flashbots#45)
0457382 
* Remove old infra scripts
* core: tx_pool not return `error` in `MevBundles()`
* Adjust worker to not consider error returned from MevBundles
* Update web3ext.go
* internal/ethapi: Fix context not being used
* fix: dev: add defer privateTx.Stop()

Co-authored-by: eugene <[email protected]>
Co-authored-by: 0x2 <[email protected]>
Co-authored-by: Nicolas Gotchac <[email protected]>
Co-authored-by: Jolly Zhao <[email protected]>
avalonche pushed a commit that referenced this pull request Mar 15, 2023
@Ruteri @gelfand
@Code0x2 @ngotchac @Jolly23 @avalonche
Cleanup and include old mev geth prs (#45)
e68f98b 
* Remove old infra scripts
* core: tx_pool not return `error` in `MevBundles()`
* Adjust worker to not consider error returned from MevBundles
* Update web3ext.go
* internal/ethapi: Fix context not being used
* fix: dev: add defer privateTx.Stop()

Co-authored-by: eugene <[email protected]>
Co-authored-by: 0x2 <[email protected]>
Co-authored-by: Nicolas Gotchac <[email protected]>
Co-authored-by: Jolly Zhao <[email protected]>
avalonche pushed a commit that referenced this pull request Mar 17, 2023
@Ruteri @gelfand
@Code0x2 @ngotchac @Jolly23 @avalonche
Cleanup and include old mev geth prs (#45)
93574bb 
* Remove old infra scripts
* core: tx_pool not return `error` in `MevBundles()`
* Adjust worker to not consider error returned from MevBundles
* Update web3ext.go
* internal/ethapi: Fix context not being used
* fix: dev: add defer privateTx.Stop()

Co-authored-by: eugene <[email protected]>
Co-authored-by: 0x2 <[email protected]>
Co-authored-by: Nicolas Gotchac <[email protected]>
Co-authored-by: Jolly Zhao <[email protected]>
avalonche added a commit that referenced this pull request Mar 17, 2023
@avalonche
Prevent uint256 overflow during conversion (#45)
3d6e95d 
* Prevent uint256 overflow during conversion

* add shanghai checks

* remove unused functions

* move validation to ValidatePayload
avalonche pushed a commit that referenced this pull request Mar 22, 2023
@Ruteri @gelfand
@Code0x2 @ngotchac @Jolly23 @avalonche
Cleanup and include old mev geth prs (#45)
a1c9267 
* Remove old infra scripts
* core: tx_pool not return `error` in `MevBundles()`
* Adjust worker to not consider error returned from MevBundles
* Update web3ext.go
* internal/ethapi: Fix context not being used
* fix: dev: add defer privateTx.Stop()

Co-authored-by: eugene <[email protected]>
Co-authored-by: 0x2 <[email protected]>
Co-authored-by: Nicolas Gotchac <[email protected]>
Co-authored-by: Jolly Zhao <[email protected]>
avalonche added a commit that referenced this pull request Mar 22, 2023
@avalonche
Prevent uint256 overflow during conversion (#45)
211bb09 
* Prevent uint256 overflow during conversion

* add shanghai checks

* remove unused functions

* move validation to ValidatePayload
avalonche pushed a commit that referenced this pull request Jul 6, 2023
@Ruteri @gelfand
@Code0x2 @ngotchac @Jolly23 @avalonche
Cleanup and include old mev geth prs (#45)
f0445c3 
* Remove old infra scripts
* core: tx_pool not return `error` in `MevBundles()`
* Adjust worker to not consider error returned from MevBundles
* Update web3ext.go
* internal/ethapi: Fix context not being used
* fix: dev: add defer privateTx.Stop()

Co-authored-by: eugene <[email protected]>
Co-authored-by: 0x2 <[email protected]>
Co-authored-by: Nicolas Gotchac <[email protected]>
Co-authored-by: Jolly Zhao <[email protected]>
avalonche added a commit that referenced this pull request Jul 6, 2023
@avalonche
Prevent uint256 overflow during conversion (#45)
7e6c90c 
* Prevent uint256 overflow during conversion

* add shanghai checks

* remove unused functions

* move validation to ValidatePayload
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Ruteri Ruteri Ruteri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avalonche @Ruteri