fix: set buildOptions in new initialize function #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codingnuclei I will need more time to test and review it, so excuse me if it hangs longer. But shallow review shows me that the fix makes sense 😀 |
|
@floydspace no worries. Let's get this right! 👍 |
samchungy
previously approved these changes
Jul 19, 2022
samchungy
approved these changes
Jul 19, 2022
|
Hey @codingnuclei , can we merge this PR? The fix will be appreciated. Thanks! |
|
@Edweis hey - so as I understand it, I am unable to merge. Think @floydspace has to 😀 |
|
Merged it, thank you for contribution |
|
🎉 This PR is included in version 1.32.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #334
Hey,
This PR ensures that the buildOptions is set in the initialize hook.
https://www.serverless.com/framework/docs/guides/plugins/creating-plugins#lifecycle-events
As per their docs the previous method meant that the serverless object passed to
config()had variables that were not resolved...Considerations:
memoizeWithas now the buildOptions is only set once. As the class field has not changed name or the returning value, no changes are required in any other file.