in_systemd: allow a parser to be specified as part of the systemd unit #9567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveas
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
seveas
force-pushed
the
systemd-parser
branch
from
21c2e24 to
c94ed77
Compare
Contributor
Author
|
Example config: The systemd unit of the service whose logs we now parse: Log output showing that |
seveas
force-pushed
the
systemd-parser
branch
from
c94ed77 to
e8a8138
Compare
Contributor
Author
|
Valgrind is happy: |
seveas
force-pushed
the
systemd-parser
branch
from
e8a8138 to
07962d7
Compare
Collaborator
|
@seveas I am trying to understand the use case here. Can you expand a bit on what is the problem you are trying to solve? |
seveas
force-pushed
the
systemd-parser
branch
from
07962d7 to
c23b26c
Compare
Contributor
Author
|
@niedbalski the trigger for this is the desire to move to yaml based configs, and the incompatibility of those and the way we build our configuration. We currently have a base config (not yaml) deployed to all hosts, it includes a systemd input and a strategically placed This is impossible to do in yaml configs, as its inclusion system only supports including full pipelines. So, taking inspiration from the kubernetes filter, where you can have one input, one filter and using metadata attached to pods, we came up with this strategy where a systemd unit can specify a parser to use, removing the need for a separate filter per systemd service and removing the need for these includes. |
Similar to how we use kubernetes annotations to determine a parser, this uses custom fields in systemd units to configure a parser per systemd unit. In the unit file this is configured as: ``` [Service] ... LogExtraFields=FLUENT_BIT_PARSER=logfmt ``` Signed-off-by: Dennis Kaarsemaker <[email protected]>
seveas
force-pushed
the
systemd-parser
branch
from
c23b26c to
f139bc5
Compare
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
hi. Can you elaborate on your use case?
|
Contributor
|
@seveas can you address both the conflicts and questions asked by reviewers? |
nourdouf
added a commit
to nourdouf/fluent-bit
that referenced
this pull request
Nov 19, 2025
This merge integrates the parser functionality from PR fluent#9567 with the current master branch's cfl_kvlist-based implementation. Changes: - Added flb_systemd_repack_map() function to repack parsed msgpack data - Added parser lookup from FLUENT_BIT_PARSER systemd journal field - Modified systemd_enumerate_data_store() to accept and apply parser - Parser is applied to MESSAGE field when specified - FLUENT_BIT_PARSER field is excluded from output - Parsed data is repacked and integrated into the log encoder The parser allows per-systemd-unit log parsing configuration via: [Service] LogExtraFields=FLUENT_BIT_PARSER=logfmt Co-authored-by: Dennis Kaarsemaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how we use kubernetes annotations to determine a parser, this
uses custom fields in systemd units to configure a parser per systemd
unit.
In the unit file this is configured as:
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.