Skip to content

Conversation

@IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Aug 17, 2023

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@IT-VBFK IT-VBFK force-pushed the fix/qodana-2 branch 2 times, most recently from adf6d64 to f030867 Compare August 17, 2023 16:34
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@IT-VBFK IT-VBFK force-pushed the fix/qodana-2 branch 3 times, most recently from 81881ce to 73d5b9a Compare August 17, 2023 16:42
@IT-VBFK IT-VBFK force-pushed the fix/qodana-2 branch 4 times, most recently from 9c55da9 to 8a9d9a9 Compare August 17, 2023 17:26
@coveralls
Copy link

coveralls commented Aug 17, 2023

Pull Request Test Coverage Report for Build 5929174797

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 97.236%

Totals Coverage Status
Change from base Build 5912924308: -0.002%
Covered Lines: 12942
Relevant Lines: 13185

💛 - Coveralls

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Aug 18, 2023

image

Hä? I don't get it 😂😂

@jnyrup
Copy link
Member

jnyrup commented Aug 18, 2023

Try adding this to VB.Specs.vbproj

<RootNamespace>VB.Specs</RootNamespace>

@IT-VBFK IT-VBFK force-pushed the fix/qodana-2 branch 6 times, most recently from a666e44 to 228097c Compare August 18, 2023 12:21
@IT-VBFK IT-VBFK force-pushed the fix/qodana-2 branch 3 times, most recently from 7b3106b to 4eeccbb Compare August 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants