Update README: Access Tokens for self-hosted tiles #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Feb 15, 2020
Collaborator
tobrun
left a comment
tobrun
left a comment
There was a problem hiding this comment.
We might want to consider changing this behavior to allow empty tokens in the future.
agreed, for now lets use this contents of this PR
Lobankovanastia
pushed a commit
to Lobankovanastia/flutter-mapbox-gl
that referenced
this pull request
Feb 15, 2020
…#217) * Update Readme: access tokens in projects not using Mapbox tiles * Update README.md
andrea689
added a commit
to andrea689/flutter-mapbox-gl
that referenced
this pull request
Mar 13, 2020
* master: Support setting map's content insets (flutter-mapbox-gl#215) Provide `onMapIdle` callback (flutter-mapbox-gl#214) [example] add full page map example (flutter-mapbox-gl#201) Fix missing location indicator on iOS (flutter-mapbox-gl#176) Returned a nil result so the future completes. (flutter-mapbox-gl#216) Update README: Access Tokens for self-hosted tiles (flutter-mapbox-gl#217) Change annotation priority (flutter-mapbox-gl#222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #142, we currently throw an error if the access token is missing or empty, even if the user doesn't use Mapbox tiles. This is now documented.
We might want to consider changing this behavior to allow empty tokens in the future.