Skip to content

fixed crashes with ios offline manager #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2021
Merged

fixed crashes with ios offline manager #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a048fb3
fixed crashes with ios offline manager
Mar 29, 2021
175cb02
removed redundant call to releaseDownloader
Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ios/Classes/OfflineManagerUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ class OfflineManagerUtils {
}
})
if let packToRemoveUnwrapped = packToRemove {
// deletion is only safe if the download is suspended
packToRemoveUnwrapped.suspend()
OfflineManagerUtils.releaseDownloader(id: id)

offlineStorage.removePack(packToRemoveUnwrapped) { error in
if let error = error {
result(FlutterError(
Expand Down
4 changes: 1 addition & 3 deletions ios/Classes/OfflinePackDownloadManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ class OfflinePackDownloader {
))
if let region = OfflineRegion.fromOfflinePack(pack) {
OfflineManagerUtils.deleteRegion(result: result, id: region.id)
OfflineManagerUtils.releaseDownloader(id:region.id)
}
}

Expand All @@ -158,7 +157,6 @@ class OfflinePackDownloader {
))
if let region = OfflineRegion.fromOfflinePack(pack) {
OfflineManagerUtils.deleteRegion(result: result, id: region.id)
OfflineManagerUtils.releaseDownloader(id: region.id)
}
}

Expand Down Expand Up @@ -193,7 +191,7 @@ class OfflinePackDownloader {
return false
}
// We can tell whether 2 packs are the same by comparing metadata we assigned earlier
return pack.context == currentlyManagedPack.context
return pack.state != .invalid && pack.context == currentlyManagedPack.context
}

private func calculateDownloadingProgress(
Expand Down