Respect native scale when adding symbols on iOS #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-ht
approved these changes
Dec 23, 2021
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 22, 2022
https: //github.com/flutter-mapbox-gl/maps/pull/835 Co-Authored-By: igorczapski <[email protected]>
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 22, 2022
* cherry-pick upstream#835 https: //github.com/flutter-mapbox-gl/maps/pull/835 Co-Authored-By: igorczapski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding symbols, the native scaling is ignored. (our app displays embedded images as well as custom images downloaded by the app). This causes the images to be displayed with different size.
Below is how it looks using the 0.14.0 version:
And here is the result with the proposed change:
Purple icon is loaded from assets, but the orange one is dynamic.