-
Couldn't load subscription status.
- Fork 361
Disable screens not compatible with DWDS websocket mode #9481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable screens not compatible with DWDS websocket mode #9481
Conversation
The DWDS websocket mode used by the Flutter `web-server` device provides a limited subset of the service protocol that doesn't include debugging capabilities, expression evaluation support, or object inspection. This change adds detection for applications running in this limited mode and hides screens that rely on unsupported functionality (e.g., debugger).
…:bkonyi/devtools into addition_dwds_websocket_protocol_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits but otherwise LGTM!
| visibleScreenTypes, | ||
| equals([ | ||
| HomeScreen, | ||
| // InspectorScreen, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented out code 😃 (here and below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirming we actually want to do this, since I think these were intentionally added to make it clear which screens should be omitted. I'm happy to remove them though if you'd prefer 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah didn't realize the test was already using this pattern. Fine by me to keep!
Updated comment to clarify web app debugging support.
The DWDS websocket mode used by the Flutter `web-server` device provides a limited subset of the service protocol that doesn't include debugging capabilities, expression evaluation support, or object inspection. This change adds detection for applications running in this limited mode and hides screens that rely on unsupported functionality (e.g., debugger).
The DWDS websocket mode used by the Flutter
web-serverdevice provides a limited subset of the service protocol that doesn't include debugging capabilities, expression evaluation support, or object inspection. This change adds detection for applications running in this limited mode and hides screens that rely on unsupported functionality (e.g., debugger).