Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Oct 20, 2025

The DWDS websocket mode used by the Flutter web-server device provides a limited subset of the service protocol that doesn't include debugging capabilities, expression evaluation support, or object inspection. This change adds detection for applications running in this limited mode and hides screens that rely on unsupported functionality (e.g., debugger).

The DWDS websocket mode used by the Flutter `web-server` device provides
a limited subset of the service protocol that doesn't include debugging
capabilities, expression evaluation support, or object inspection. This
change adds detection for applications running in this limited mode and
hides screens that rely on unsupported functionality (e.g., debugger).
@bkonyi bkonyi requested a review from elliette October 20, 2025 15:45
@bkonyi bkonyi requested review from a team and kenzieschmoll as code owners October 20, 2025 15:45
@bkonyi bkonyi requested a review from elliette October 22, 2025 17:02
Copy link
Member

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits but otherwise LGTM!

visibleScreenTypes,
equals([
HomeScreen,
// InspectorScreen,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code 😃 (here and below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming we actually want to do this, since I think these were intentionally added to make it clear which screens should be omitted. I'm happy to remove them though if you'd prefer 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't realize the test was already using this pattern. Fine by me to keep!

Updated comment to clarify web app debugging support.
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2025
@bkonyi bkonyi merged commit 1f8b3f5 into flutter:master Oct 24, 2025
36 checks passed
@bkonyi bkonyi deleted the addition_dwds_websocket_protocol_support branch October 24, 2025 17:42
srawlins pushed a commit that referenced this pull request Oct 28, 2025
The DWDS websocket mode used by the Flutter `web-server` device provides
a limited subset of the service protocol that doesn't include debugging
capabilities, expression evaluation support, or object inspection. This
change adds detection for applications running in this limited mode and
hides screens that rely on unsupported functionality (e.g., debugger).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants