Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web_ui/dev/felt_windows.bat
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ IF %orTempValue%==0 (
:: TODO(nurhan): The batch script does not support snanphot option.
:: Support snapshot option.
CALL :installdeps
%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %*
IF %1==test (%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* --browser=edge) ELSE ( %DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* )

EXIT /B 0

Expand Down
12 changes: 8 additions & 4 deletions lib/web_ui/test/dom_renderer_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ void main() {
expect(parent.innerHtml, '<a></a><b></b><c></c><d></d>');
});

test('inneheight/innerWidth are equal to visualViewport height and width', () {
test('innerHeight/innerWidth are equal to visualViewport height and width',
() {
if (html.window.visualViewport != null) {
expect(html.window.visualViewport.width, html.window.innerWidth);
expect(html.window.visualViewport.height, html.window.innerHeight);
Expand All @@ -115,13 +116,16 @@ void main() {

final DomRenderer renderer = DomRenderer();
renderer.reset();
}, // TODO(nurhan): https://github.com/flutter/flutter/issues/46638
skip: (browserEngine == BrowserEngine.firefox));
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/46638
// TODO(nurhan): https://github.com/flutter/flutter/issues/50828
skip: (browserEngine == BrowserEngine.firefox ||
browserEngine == BrowserEngine.edge));

test('accesibility placeholder is attached after creation', () {
DomRenderer();

expect(html.document.getElementsByTagName('flt-semantics-placeholder'),
isNotEmpty);
isNotEmpty);
});
}
20 changes: 15 additions & 5 deletions lib/web_ui/test/engine/history_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ void main() {

// The flutter entry is the current entry.
expect(strategy.currentEntry, flutterEntry);
});
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
skip: browserEngine == BrowserEngine.edge);

test('browser back button pops routes correctly', () async {
strategy =
Expand Down Expand Up @@ -90,7 +92,9 @@ void main() {
// The url of the current entry (flutter entry) should go back to /home.
expect(strategy.currentEntry.state, flutterState);
expect(strategy.currentEntry.url, '/home');
});
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
skip: browserEngine == BrowserEngine.edge);

test('multiple browser back clicks', () async {
strategy =
Expand Down Expand Up @@ -151,7 +155,9 @@ void main() {
// 3. The active entry doesn't belong to our history anymore because we
// navigated past it.
expect(strategy.currentEntryIndex, -1);
});
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
skip: browserEngine == BrowserEngine.edge);

test('handle user-provided url', () async {
strategy =
Expand Down Expand Up @@ -190,7 +196,9 @@ void main() {
expect(strategy.currentEntryIndex, 1);
expect(strategy.currentEntry.state, flutterState);
expect(strategy.currentEntry.url, '/home');
});
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
skip: browserEngine == BrowserEngine.edge);

test('user types unknown url', () async {
strategy =
Expand All @@ -212,7 +220,9 @@ void main() {
expect(strategy.currentEntryIndex, 1);
expect(strategy.currentEntry.state, flutterState);
expect(strategy.currentEntry.url, '/home');
});
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
skip: browserEngine == BrowserEngine.edge);
});
}

Expand Down
8 changes: 5 additions & 3 deletions lib/web_ui/test/engine/semantics/semantics_helper_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ void main() {
desktopSemanticsEnabler.tryEnableSemantics(event);

expect(shouldForwardToFramework, true);
});
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);

test(
'Relevants events targeting placeholder should not be forwarded to the framework',
Expand Down Expand Up @@ -149,7 +151,7 @@ void main() {
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
// TODO(nurhan): https://github.com/flutter/flutter/issues/46638
skip: (browserEngine == BrowserEngine.firefox ||
browserEngine == BrowserEngine.webkit));
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine != BrowserEngine.blink);
});
}
Loading