This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Improve TextInputPlugin test readability #39664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Feb 16, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm
Show resolved
Hide resolved
loic-sharma
reviewed
Feb 16, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm
Show resolved
Hide resolved
loic-sharma
reviewed
Feb 16, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm
Outdated
Show resolved
Hide resolved
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code. While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like `handleDefaultSetClientCall`, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit. Followup patch to #39632. Issue: flutter/flutter#120252
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2023
…120850) * b7ec9ce18 [macOS] Improve TextInputPlugin test readability (flutter/engine#39664) * a6e8fb134 Roll Dart SDK from a594e34e85b6 to ce9397c5fc8f (1 revision) (flutter/engine#39667) * 3fc40ca5b ++ (flutter/engine#39617)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code.
While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like
handleDefaultSetClientCall, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit.Followup patch to #39632.
Issue: flutter/flutter#120252
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.