[flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables #7688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onst_literals_to_create_immutables
3 tasks
|
I believe this PR is except from the changelog check, as we're intentionally staging this change in prep for a publish once the next major version of package:lints is available. |
devoncarew
added
the
override: no versioning needed
|
cc @Piinks and @stuartmorgan as likely reviewers (normally I would ask @goderbauer for a review here / he would author the PR). |
stuartmorgan-g
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
LGTM mechanically; I haven't had any direct involvement with this package before so I have no idea what the policies on changes are, or how it's versioned.
(E.g., this is the correct way to land in this repo if you explicitly don't want to publish right now, so RSLGTM on landing an unpublished change in the first place, but LGTM on this given that goal.)
Great! Yup, this is the intent. We'll follow this up near-term with a rev to some deps and to a new major version, and plan to publish that. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
…t_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
…t_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 25, 2024
flutter/packages@4926c0f...7da2374 2024-09-25 [email protected] Update test to not depend on `Color.toString()` (flutter/packages#7701) 2024-09-25 [email protected] [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688) 2024-09-24 [email protected] [go_router] Fixed TabView swiping in custom stateful shell route example (flutter/packages#7583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
flutter/packages@4926c0f...7da2374 2024-09-25 [email protected] Update test to not depend on `Color.toString()` (flutter/packages#7701) 2024-09-25 [email protected] [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688) 2024-09-24 [email protected] [go_router] Fixed TabView swiping in custom stateful shell route example (flutter/packages#7583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
flutter/packages@4926c0f...7da2374 2024-09-25 [email protected] Update test to not depend on `Color.toString()` (flutter/packages#7701) 2024-09-25 [email protected] [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688) 2024-09-24 [email protected] [go_router] Fixed TabView swiping in custom stateful shell route example (flutter/packages#7583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
flutter/packages@4926c0f...7da2374 2024-09-25 [email protected] Update test to not depend on `Color.toString()` (flutter/packages#7701) 2024-09-25 [email protected] [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688) 2024-09-24 [email protected] [go_router] Fixed TabView swiping in custom stateful shell route example (flutter/packages#7583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
flutter/packages@4926c0f...7da2374 2024-09-25 [email protected] Update test to not depend on `Color.toString()` (flutter/packages#7701) 2024-09-25 [email protected] [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688) 2024-09-24 [email protected] [go_router] Fixed TabView swiping in custom stateful shell route example (flutter/packages#7583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TechnicJelle
added a commit
to TechnicJelle/BlueMapGUI
that referenced
this pull request
Sep 19, 2025
Apparently they got disabled by default at some point, but I like them, so we're keeping them. dart-lang/core#833 flutter/packages#7688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes three const lints from package:flutter_lints:
prefer_const_constructors,prefer_const_declarations, andprefer_const_literals_to_create_immutables.This PR does not rev the pubspec version. We want to stage this change out in coordination with package:lints; see dart-lang/core#834.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.