-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[android_intent] Added "action_location_source_settings" action to start Location Settings Activity #1867
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
bparrishMines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
The android_intent code looks good, but it looks like you included .iml files. Could you remove these?
Done |
bparrishMines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I added a version bump and will merge once tests pass.
…art Location Settings Activity (flutter#1867)
…art Location Settings Activity (flutter#1867)
…art Location Settings Activity (flutter#1867)
Description
Added
'action_location_source_settings'action to open the Location Settings Activity. This is useful when we need the user to enable/disable your Location.Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change