Skip to content

fix: reloadUrl will not return Future #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix: reloadUrl will not return Future #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions android/src/main/java/com/flutter_webview_plugin/FlutterWebviewPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ private void stopLoading(MethodCall call, MethodChannel.Result result) {
if (webViewManager != null) {
webViewManager.stopLoading(call, result);
}
result.success(null);
}

private void close(MethodCall call, MethodChannel.Result result) {
Expand All @@ -163,6 +164,7 @@ private void back(MethodCall call, MethodChannel.Result result) {
if (webViewManager != null) {
webViewManager.back(call, result);
}
result.success(null);
}

/**
Expand All @@ -172,6 +174,7 @@ private void forward(MethodCall call, MethodChannel.Result result) {
if (webViewManager != null) {
webViewManager.forward(call, result);
}
result.success(null);
}

/**
Expand All @@ -181,13 +184,15 @@ private void reload(MethodCall call, MethodChannel.Result result) {
if (webViewManager != null) {
webViewManager.reload(call, result);
}
result.success(null);
}

private void reloadUrl(MethodCall call, MethodChannel.Result result) {
if (webViewManager != null) {
String url = call.argument("url");
webViewManager.reloadUrl(url);
}
result.success(null);
}

private void eval(MethodCall call, final MethodChannel.Result result) {
Expand All @@ -208,12 +213,14 @@ private void hide(MethodCall call, final MethodChannel.Result result) {
if (webViewManager != null) {
webViewManager.hide(call, result);
}
result.success(null);
}

private void show(MethodCall call, final MethodChannel.Result result) {
if (webViewManager != null) {
webViewManager.show(call, result);
}
result.success(null);
}

private void cleanCookies(MethodCall call, final MethodChannel.Result result) {
Expand Down