Skip to content

Fixed error methods on iOS #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2019
Merged

Fixed error methods on iOS #551

merged 1 commit into from
Nov 14, 2019

Conversation

floorish
Copy link
Contributor

  • Call correct method on channel (onError -> onHttpError)
  • Only send error message if http status code >= 400
  • Send didFailProvisionalNavigation error messages (e.g. no internet connection)

@charafau charafau merged commit 38776a8 into fluttercommunity:master Nov 14, 2019
charafau pushed a commit that referenced this pull request Apr 7, 2020
@floorish @charafau
Fixed error methods on iOS (#551)
80ee964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floorish @charafau