Add ignore ssl error parameter #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could anyone merge this please? Thanks! @charafau |
|
Sorry was busy lately, will review today. |
|
works like a charm, thank you ! |
|
thanks so much @charafau ! any idea when this would be pushed into pub as a new version ? |
|
thanks @charafau, glad to hear everything worked fine. And thanks again for all the work you put into this package. |
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
* add ignoreSSLErrors parameter - just Android * iOS implementation to allow ignore SSL Errors * add documentation for ignoreSSLErrorsFlag * remove log messages used for ignorSSLErrors debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #298 where in certain situations users have to ignore SSL certificates, e.g when working in test environments with self-signed certificates.
The new optional flag ignoreSSLErrors which defaults to false allows just that.