change param reference webState Change to map<String,dynamic> into map<dynamic,dynamic> #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejard-h
reviewed
May 24, 2018
| WebViewStateChanged(this.type, this.url, this.navigationType); | ||
|
|
||
| factory WebViewStateChanged.fromMap(Map<String, dynamic> map) { | ||
| factory WebViewStateChanged.fromMap(Map<dynamic, dynamic> map) { |
There was a problem hiding this comment.
I would no change the type here, to keep it type safe, I would cast le value passed to WebViewStateChanged.fromMap instead
|
Hi, thanks for your contribution, I added some comments. |
|
I did not have the issue on the last version of flutter, but I include the change myself for the last release. Thanks you and sorry :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got exception when load url
#81