Add 'show', 'hide', and 'reloadUrl' functions #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejard-h
requested changes
Jun 2, 2018
| boolean canGoForward() { | ||
| return webView.canGoForward(); | ||
| } | ||
| void hide(MethodCall call, MethodChannel.Result result) { |
ios/Classes/FlutterWebviewPlugin.m
Outdated
| } else if ([@"resize" isEqualToString:call.method]) { | ||
| [self resize:call]; | ||
| result(nil); | ||
| } else if ([@"reloadUrl" isEqualToString:call.method]) { |
|
Are you waiting for anything from me on this? |
lejard-h
approved these changes
Jun 26, 2018
Open
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
Add 'show', 'hide', and 'reloadUrl' functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods allow you to use an embedded web view in cases where you will need to hide/show the web view (for example, in a tabview). The reloadUrl is when you wish to re-use the web view with a different URL without destroying it.
There are also a few changes to .gitignore (it seems not enough files are being excluded). I also updated some of the build files to use a newer version of gradle, etc.