Fix issue 30, fully support OSS VPC endpoint #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dengqinsi Please help to review the PR, the issue has blocked our production environment. Many thanks. |
mangqin-hy
changed the title
|
@xiaozhu36 Can you help with this? |
|
HI. @benjaminguttmann-avtq I am sorry for late reply. There is a conflict and please resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #30. In the current version, some of the storage API will compose the OSS endpoint to public endpoint even the user actually want to use VPC endpoint.
The fix is simple by assuming that if the connection endpoint contains '-internal', then it must be vpc endpoint, then the implementation can compose the right endpoint.