This repository was archived by the owner on Apr 30, 2018. It is now read-only.
fix(formlyConfig): fix defaultOptions override behavior #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the override behavior when the extended type's defaultOptions field is defined as a function. Closes formly-js#635
Member
|
Hi @seibs! Thanks for the PR! This looks great to me, could I have someone from @formly-js/angular-formly-collaborators or @formly-js/angular-formly-collaborators-read review this as well? |
|
LGTM :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When the defaultOptions of a type are defined as a function and a different type extends it, the defaultOptions of the extending type are not correct.
Why
It is a bug.
How
The ordering in the reverseDeepMerge() function was reversed and the incorrect object was being returned. This change flips the parameters and returns the correct object.
For issue #635
Checklist:
Fix the override behavior when the extended type's defaultOptions field is defined as a function.
Closes #635