Skip to content

Add type hint #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 14, 2024
Merged

Add type hint #184

merged 7 commits into from
Sep 14, 2024

Conversation

@hkkim2021
Copy link
Contributor

@hkkim2021 hkkim2021 commented Sep 10, 2024 •
edited by soimkim
Loading

Description

Add type hint about fosslight_source_scanner's functions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Sep 11, 2024
@soimkim
Copy link
Contributor

soimkim commented Sep 11, 2024 •
edited
Loading

@hkkim2021 , DCO 확인 부탁드립니다. https://github.com/fosslight/fosslight_source_scanner/pull/184/checks?check_run_id=29919252553

tox -e release시 발생하는 에러 확인해주십시오.
https://github.com/fosslight/fosslight_source_scanner/actions/runs/10788453242/job/29965964140?pr=184

@hkkim2021
type_hint 추가
67b88d9 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
second commit
39626d7 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
third commit
bf58ff1 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
fourth commit
331d2cf 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
fifth commit
95966d2 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
sixth commit
b39fc6c 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
7th commit
9463803 
Signed-off-by: hkkim <[email protected]>
@hkkim2021
Copy link
Contributor Author

hkkim2021 commented Sep 12, 2024

수정 완료했습니다.

@soimkim soimkim changed the title Add type hint (함수 타입 힌트 추가) Add type hint Sep 14, 2024
@soimkim soimkim merged commit d7986e5 into fosslight:main Sep 14, 2024
@soimkim soimkim self-requested a review September 14, 2024 07:39
@soimkim soimkim linked an issue Oct 13, 2024 that may be closed by this pull request
add type hint #172
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soimkim soimkim Awaiting requested review from soimkim

Assignees

@hkkim2021 hkkim2021

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add type hint

2 participants

@hkkim2021 @soimkim