Skip to content

Add option for printing matched text #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2021
Merged

Add option for printing matched text #28

merged 2 commits into from
Aug 13, 2021

Conversation

soimkim
Copy link
Contributor

@soimkim soimkim commented Aug 12, 2021 •
edited
Loading

Description

When running, adding the -m option adds a sheet called matched_text to the output spreadsheet.
ex) matched_text sheet :

Category License Matched Text File Count Files
Copyleft GPL-2.0 GPL licensed 2 test/a, test/b

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim self-assigned this Aug 12, 2021
@soimkim soimkim added the enhancement [PR/Issue] New feature or request label Aug 12, 2021
@soimkim soimkim requested review from bjk7119 and dd-jy August 12, 2021 08:13
@soimkim soimkim added the minor [PR version] Minor version up (ex, vA.B.C : B version up) label Aug 12, 2021
@soimkim
Copy link
Contributor Author

soimkim commented Aug 12, 2021

@dd-jy , @bjk7119 ,
Please review this PR.

dd-jy
dd-jy approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@dd-jy dd-jy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick implementation!

@soimkim soimkim merged commit 89ff2fc into main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd-jy dd-jy dd-jy approved these changes

@bjk7119 bjk7119 bjk7119 approved these changes

Assignees

@soimkim soimkim

Labels
enhancement [PR/Issue] New feature or request minor [PR version] Minor version up (ex, vA.B.C : B version up)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soimkim @dd-jy @bjk7119