Skip to content

Conversation

JustinWonjaePark
Copy link
Contributor

Description

  1. Add matched lines, fileURL, vendor information when printing a row
  2. Remove additional information from SCANOSS scan when output format is set as Opossum report
  3. Add extended_header and provide it when writing output file at FOSSlight util

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JustinWonjaePark JustinWonjaePark added the enhancement [PR/Issue] New feature or request label Dec 23, 2021
@soimkim soimkim self-requested a review December 24, 2021 01:10
Copy link
Contributor

@soimkim soimkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinWonjaePark ,
Due to scanoss, the output is too complicated.

How about splitting get_row_to_print into another function when the output contains scanoss and the output is not json?

@JustinWonjaePark JustinWonjaePark force-pushed the new_add_scanoss_information_on_spreadsheet branch from 6835ae7 to 8a858e6 Compare December 30, 2021 06:52
@soimkim
Copy link
Contributor

soimkim commented Dec 30, 2021

Awesome!

@soimkim soimkim merged commit 9dd42f0 into fosslight:develop Dec 30, 2021
@JustinWonjaePark JustinWonjaePark deleted the new_add_scanoss_information_on_spreadsheet branch January 10, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [PR/Issue] New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants