Skip to content

Conversation

@iqbal-saraf
Copy link

This adds new quantizer namely QmaxDynamic which includes all functionality providing a dynamic version of Qmax, Qminmax and pertokenmax. Additionally, it allows perCh or pertoken quantization features.

Related issues or PRs

None

How to verify the PR

All previous tests build for Qmax, Qminmax and pertokenmax should invoke this new quantizer.

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added (if that coverage is difficult, please briefly explain the reason)
  • I have ensured all unit tests pass

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <[email protected]>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

@github-actions github-actions bot added the feat label Jun 16, 2025
@iqbal-saraf iqbal-saraf mentioned this pull request Jun 16, 2025
8 tasks
@chichun-charlie-liu chichun-charlie-liu marked this pull request as ready for review July 16, 2025 20:38
@chichun-charlie-liu chichun-charlie-liu merged commit d555ef5 into foundation-model-stack:main Jul 16, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants