feat(anvil): Implement alloy_evm FromRecoveredTx trait for anvil TypedTransaction
#12424
+110
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypedTransaction`
mablr
changed the title
FromRecoveredTx trait for anvil `T…FromRecoveredTx trait for anvil TypedTransaction
…es except deposit
mablr
commented
Nov 4, 2025
Comment on lines
+1367
to
+1382
| let TxDeposit { to, value, gas_limit, input, .. } = tx; | ||
|
|
||
| Self { | ||
| caller, | ||
| kind: transact_to(to), | ||
| data: input.clone(), | ||
| chain_id: tx.chain_id(), | ||
| nonce: 0, | ||
| value: *value, | ||
| gas_price: 0, | ||
| gas_priority_fee: None, | ||
| gas_limit: *gas_limit, | ||
| access_list: vec![].into(), | ||
| tx_type: DEPOSIT_TX_TYPE_ID, | ||
| ..Default::default() | ||
| } |
There was a problem hiding this comment.
To replace this with
Self::from_recovered_tx(tx, caller)
We need to bump alloy-evm to "0.23.0", but it relies on revm-precompile "29.0.0", while current foundry's revm version "30.2.0" relies on revm-precompile "28.1.1".
So the we need to bump revm to "31.0.0", but ... this change breaks alloy-evm "0.23.0",
bluealloy/revm@ce68f93
So I'll make a pr on alloy-evm to fix that, then we'll to cut a release and bump everything here...
There was a problem hiding this comment.
pending alloy-rs/evm#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #12390
Solution
Implement alloy_evm
FromRecoveredTxtrait for anvilTypedTransaction. Just copy-pasted existing conversion for now, but will changed once the following will done:Pending alloy-rs/evm#209
... Before being merged, this PR needs to be rebased on #12406, and the test updated accordingly (tx json structure, see #12406 (comment))
PR Checklist