-
Notifications
You must be signed in to change notification settings - Fork 9
Closed as not planned
Labels
part:coreAffects the core types (`Sender`, `Receiver`, exceptions, etc.)Affects the core types (`Sender`, `Receiver`, exceptions, etc.)resolution:invalidThis doesn't seem rightThis doesn't seem righttype:bugSomething isn't workingSomething isn't working
Description
It looks like ordering is important here and I don't think set preserves order. Also, why do we want to compress FileChanges that are the same, suppose we have this sequence:
/ais added/ais deleted/ais added again
With this implementation we could only get one add and one deletion so we would think the file doesn't exist but it does.
If this introduced a bug that wasn't detected by test, we should probably add a test for this too :)
Originally posted by @leandro-lucarella-frequenz in #42 (comment)
Metadata
Metadata
Assignees
Labels
part:coreAffects the core types (`Sender`, `Receiver`, exceptions, etc.)Affects the core types (`Sender`, `Receiver`, exceptions, etc.)resolution:invalidThis doesn't seem rightThis doesn't seem righttype:bugSomething isn't workingSomething isn't working