Enable merge queue #108
Merged
Enable merge queue #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leandro-lucarella-frequenz
commented
May 24, 2023
leandro-lucarella-frequenz
commented
- Test docs generation more widely
- Be a bit more strict when limiting to tags
- Trigger CI workflow on merge queues
- Add a dummy workflow to succeed DCO check on merge queues
We allow the docs generation test to run for any trigger but `push`, so for exampmle `workflow_dispatch` will also run the test. We rename the job accordingly also to `test-generate-docs`. The `push` event is still skipped because it already runs a job to generate the final documentation, so we don't need to test it too. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
For this to work properly we need to exclude the branches starting with `gh-readonly-queue/` for pushes, otherwise PRs will be tested twice, once as the PR and the second one when they are pushed to the `gh-readonly-queue/...` branch. We do run the tests for the merge queue merge commit as it might include several PRs being merged at the same time, so we want to test the merge. Signed-off-by: Leandro Lucarella <[email protected]>
The DCO bot is not running on merge queues, so if we require the check it will hang forever for merge queues. See frequenz-floss/frequenz-sdk-python#363 for more details. Signed-off-by: Leandro Lucarella <[email protected]>
leandro-lucarella-frequenz
added
the
type:tech-debt
github-actions
bot
added
the
part:tooling
Contributor
Author
|
Enabled auto-merge. |
shsms
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.