Use "aware" datetimes #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandro-lucarella-frequenz
added
priority:high
github-actions
bot
added
part:channels
Signed-off-by: Leandro Lucarella <[email protected]>
When creating datetimes we need to make sure to include timezone information, otherwise we will get exceptions raised when comparing to other "aware" datetime objects. Using "native" datetime object (without timezone information) is very dangerous as we might mix datetimes created for different timezones without knowing, introducing very obscure bugs. More info about "aware" and "native" datetimes: https://docs.python.org/3/library/datetime.html#aware-and-naive-objects Signed-off-by: Leandro Lucarella <[email protected]>
leandro-lucarella-frequenz
force-pushed
the
fix-now
branch
from
b4ae9d7 to
4ff417d
Compare
Contributor
Author
|
For more context, this is affecting some tests in the SDK, which was really hard to figure out. |
leandro-lucarella-frequenz
requested a review
from sahas-subramanian-frequenz
sahas-subramanian-frequenz
approved these changes
Nov 16, 2022
Contributor
sahas-subramanian-frequenz
left a comment
sahas-subramanian-frequenz
left a comment
There was a problem hiding this comment.
Oops, that makes sense. Thanks Luca!
Contributor
Author
|
It is quite inconvenient (:hankey:) that Python doesn't use "aware" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating datetimes we need to make sure to include timezone information, otherwise we will get exceptions raised when comparing to other "aware" datetime objects. Using "native" datetime object (without timezone information) is very dangerous as we might mix datetimes created for different timezones without knowing, introducing very obscure bugs.
More info about "aware" and "native" datetimes: https://docs.python.org/3/library/datetime.html#aware-and-naive-objects