Skip to content

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 23, 2020

After recent update, the Git Blame line no longer shows the buttons in Sublime Text 4,

image

and logs the following error in the console:

Parse Error: _num=24&">[Prev]</a>
                2addc0883630
                <a href="copy?sha=2addc0883630">[Copy]</a>
                <a href="show?sha=2addc0883630">[Show]</a>
                <a class="close" href="close">×</a>
            </span>
        </div>
    </body>
 code: Unexpected character

Let's escape the ampersands to prevent this.

After recent update, the Git Blame line no longer shows the buttons in Sublime Text 4,
and logs the following error in the console:

	Parse Error: _num=24&">[Prev]</a>
	                2addc0883630
	                <a href="copy?sha=2addc0883630">[Copy]</a>
	                <a href="show?sha=2addc0883630">[Show]</a>
	                <a class="close" href="close">×</a>
	            </span>
	        </div>
	    </body>
	 code: Unexpected character

Let's escape the ampersands to prevent this.
@frou frou merged commit 04a0c20 into frou:master Aug 23, 2020
@frou
Copy link
Owner

frou commented Aug 23, 2020

Thank you. I wasn't aware that this kind of escaping was required inside HTML attribute values.

I'll release a new version including this fix to Package Control later today.

@jtojnar jtojnar deleted the escape-amps branch August 23, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants