Upgrade vscode and fix windows #92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MangelMaxime , can you try rebasing on latest master to see if this fixes the tests? |
|
Sure will do |
MangelMaxime
force-pushed
the
upgrade_vscode_and_fix_windows
branch
from
5556003 to
8d4399a
Compare
|
The CI is indeed fixed. I don't know why the one test is still failing locally for me. The one about CSharp reference but it is not a problem to me if the CI validate the build. |
|
Closing because this is no longer relevant. We are way past this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to work on some issues/improvements I would like to propose to fsharp-language-server and encountered some problem for running the project.
Here is a list of the issues and solution I followed to fix them:
When running
npm installI got:A solution is proposed on this issue microsoft/vscode#119822 (comment) linking to a migration guide.
I followed the migration guide but didn't installed the
vscode-testextensions because I don't think this project is running debugging inside of the VSCode.After that I got an error from the TypeScript compiler
TS2304: Cannot find name 'unknown'.In order, to fix it I upgraded the TypeScript compiler to latest version as
unkownhas been introduced in version 3 and the project was using version 2.After that I got an error from the TypeScript compiler
TS2300: Duplicate identifier 'IteratorResult'.This time I upgraded
@types/nodeto the latest version.When running the extension via the
Extensiondebug task, I had the errorCouldn't start client F# Language Server. The problem, was that on windows the command name as used infindInPathshould bedotnet.exeand not justdotnet.I added a platform detection so choose the right name to follow the actual code. But personally, I would just change the code to
serverOptions = { - command: findInPath(commandName), + command: "dotnet", args: ['run', '--project', 'src/FSharpLanguageServer'], transport: TransportKind.stdio, options: { cwd: context.extensionPath } }because the
findInPathdoesn't really provide anything. We don't add an error message or anything currently to help debug the issue.Edit: If you want me to change the code to remove
findInPathplease tell me, I will update the PR or create a new one.