Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/createClassProxy.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function addProxy(Component, proxy) {
allProxies.push([Component, proxy]);
}

function proxyClass(InitialComponent) {
function proxyClass(InitialComponent, ErrorComponent) {
// Prevent double wrapping.
// Given a proxy class, return the existing proxy managing it.
var existingProxy = findProxy(InitialComponent);
Expand Down Expand Up @@ -103,7 +103,7 @@ function proxyClass(InitialComponent) {
let prototypeProxy;
if (InitialComponent.prototype && InitialComponent.prototype.isReactComponent) {
// Point proxy constructor to the proxy prototype
prototypeProxy = createPrototypeProxy();
prototypeProxy = createPrototypeProxy(ErrorComponent);
ProxyComponent.prototype = prototypeProxy.get();
}

Expand Down Expand Up @@ -257,8 +257,8 @@ function createFallback(Component) {
};
}

export default function createClassProxy(Component) {
export default function createClassProxy(Component, ErrorComponent) {
return Component.__proto__ && supportsProtoAssignment() ?
proxyClass(Component) :
proxyClass(Component, ErrorComponent) :
createFallback(Component);
}
22 changes: 21 additions & 1 deletion src/createPrototypeProxy.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import React from "react";
import assign from 'lodash/assign';
import difference from 'lodash/difference';

export default function createPrototypeProxy() {
export default function createPrototypeProxy(ErrorComponent) {
let proxy = {};
let current = null;
let mountedInstances = [];
Expand Down Expand Up @@ -43,6 +44,20 @@ export default function createPrototypeProxy() {
return proxiedMethod;
}

/**
* Augments the original render with exception handling & rendering.
*/
function proxiedRender() {
if (typeof current.render === 'function') {
try {
return current.render.apply(this, arguments);
} catch (ex) {
return React.createElement(ErrorComponent, { error: ex });
}
}
}
proxiedRender.toString = proxyToString('render');

/**
* Augments the original componentDidMount with instance tracking.
*/
Expand Down Expand Up @@ -158,6 +173,11 @@ export default function createPrototypeProxy() {
}
});

// Error catching for render
if (typeof ErrorComponent !== 'undefined') {
defineProxyPropertyWithValue('render', proxiedRender);
}

// Track mounting and unmounting
defineProxyPropertyWithValue('componentDidMount', proxiedComponentDidMount);
defineProxyPropertyWithValue('componentWillUnmount', proxiedComponentWillUnmount);
Expand Down
58 changes: 54 additions & 4 deletions test/consistency.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,13 @@ function createModernFixtures() {
}
delete Anon.name;

return { Bar, Baz, Foo, Anon };
class Broken extends React.Component {
render() {
throw new Error('mistakes were made');
}
}

return { Bar, Baz, Foo, Anon, Broken };
}

function createClassicFixtures() {
Expand Down Expand Up @@ -101,7 +107,13 @@ function createClassicFixtures() {
});
delete Anon.displayName;

return { Bar, Baz, Foo, Anon };
const Broken = React.createClass({
render() {
throw new Error('mistakes were made');
}
});

return { Bar, Baz, Foo, Anon, Broken };
}

describe('consistency', () => {
Expand All @@ -119,9 +131,9 @@ describe('consistency', () => {
});

function runCommonTests(createFixtures) {
let Bar, Baz, Foo, Anon;
let Bar, Baz, Foo, Anon, Broken;
beforeEach(() => {
({ Foo, Bar, Baz, Anon } = createFixtures());
({ Foo, Bar, Baz, Anon, Broken } = createFixtures());
});

it('does not overwrite the original class', () => {
Expand Down Expand Up @@ -284,6 +296,44 @@ describe('consistency', () => {
const Proxy = proxy.get();
expect(() => renderer.render(<Proxy />)).toThrow('Oops');
});

it('can use error component for catching errors', () => {
function ErrorHandler({ error }) {
return <p>{error.message}</p>;
}
let proxy = createProxy(Broken, ErrorHandler);
const Proxy = proxy.get();
expect(() => renderer.render(<Proxy />)).toNotThrow();
const output = renderer.getRenderOutput()
expect(output.type).toEqual(ErrorHandler);
expect(output.props.error).toBeAn(Error);
expect(output.props.error.message).toEqual('mistakes were made');
});

it('still throws errors if no error component supplied', () => {
let proxy = createProxy(Broken);
const Proxy = proxy.get();
expect(() => renderer.render(<Proxy />)).toThrow();
});

it('can recover after handling an error', () => {
function ErrorHandler({ error }) {
return <p>{error.message}</p>;
}
let proxy = createProxy(Bar, ErrorHandler);
const Proxy = proxy.get();

expect(() => renderer.render(<Proxy />)).toNotThrow();
expect(renderer.getRenderOutput().props.children).toEqual('Bar');

proxy.update(Broken);
expect(() => renderer.render(<Proxy />)).toNotThrow();
expect(renderer.getRenderOutput().type).toEqual(ErrorHandler);

proxy.update(Baz);
expect(() => renderer.render(<Proxy />)).toNotThrow();
expect(renderer.getRenderOutput().props.children).toEqual('Baz');
});
}

describe('classic', () => {
Expand Down