Honor http policy #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow clients to have a means of using https for their resource manager, this change enables that behavior ONLY in cases where no resource manager address is provided. In this case, the module will first check if the http policy is HTTPS_ONLY and, in such case, construct the appropriate endpoint. Note that the changes are minimally evasive so as to prevent clients from having to change code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not honor the configured HTTP policy within
yarn-site.xml. As a result, if the HTTP policy reflectsHTTPS_ONLY, the ResourceManager object will fail. These changes allow for installations to leverage HTTPS when using the default configuration. That is, HTTPS is still not supported if anaddressis provided toResourceManagerdue to the fact that the protocol is not conveyed in the request.Once PR #34 is merged (requires a new release), we can then interrogate the protocol to determine that HTTPS has been requested. (Note: these changes will likely be warranted following #34's merge.)