Skip to content

Conversation

@weiihann
Copy link
Collaborator

Description

This PR imports a commit from upstream to fix Prometheus metrics due to incorrect naming standards.

Rationale

If we try to scrape the Prometheus metrics, an error will occur. Here's an example output of http://<prometheus-server-ip>:9090/targets:

image

After applying the fix, the Prometheus metric is working as expected. An example below shows the Grafana dashboard:
image

Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gballet gballet merged commit 80e148b into gballet:kaustinen-with-shapella Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants