Clean up text and add I/O Register quick reference #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSOtm
requested changes
Sep 19, 2020
content/Memory_Map.md
Outdated
| \<1.8) don't emulate Echo RAM. It is possible to check if Echo RAM is | ||
| properly emulated by writing to WRAM (avoid values 00 and FF) and | ||
| checking if said value is mirrored in Echo RAM. | ||
| The range at E000-FDFF connects to WRAM, but only the lower 13 bits of |
There was a problem hiding this comment.
Maybe "the entire range C000-FDFF is mapped to WRAM, but only ..."?
content/Memory_Map.md
Outdated
| seemingly random values on CGB. | ||
| Nintendo indicates use of this area is prohibited. It appears to not | ||
| connect anywhere or to otherwise have no function. Reads return 00 on | ||
| DMG, and alternate between 00 and seemingly random values on CGB. |
There was a problem hiding this comment.
It's actually revision-dependent! Ask @LIJI32 about that.
There was a problem hiding this comment.
The current fix is good enough, but maybe this is a good opportunity to document Liji's findings.
| (avoid values 00 and FF) and checking if said value is mirrored in Echo | ||
| RAM. | ||
|
|
||
| # I/O Registers |
There was a problem hiding this comment.
This is redundant, instead the table of contents should be made to display more than the first level of titles.
RetroEdit
reviewed
Oct 1, 2020
|
@ISSOtm can you check the changes you requested and mark the conversations as resolved if they look good to you? |
|
Done! |
|
Did a couple of more fixes. Looks now good to be merged, thanks @ISSOtm , @RetroEdit, @LIJI32 and @jrmoserbaltimore for the work here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an I/O register quick reference and rewrites the other sections to incorporate information from Nintendo and clarify.