Fix reg cannot scan vulnerabilities on images with empty layers #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jzelinskie can you make sure this seems right to you too, thanks! |
|
I think this change is correct, but it took me far longer to understand than it should. The filtering stuff needs to get pulled out into its own function and maybe be applied just before POSTing. That way we can keep track of these invariants in one place, rather than all over the place. |
|
I don't understand why it's hard to understand but yes, the empty layer filtering can be extracted from the function to make it more clear. I'll update the PR. |
Instead of filtering the empty layers when getting the layer, we do it before posting the layer.
KeyboardNerd
force-pushed
the
clair_v2_fix
branch
from
c6db7a4 to
7e1d6a0
Compare
|
cool fixed @jzelinskie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of layer was not properly computed because some empty layer causes the layer map to have missing indexes.
Fixes #167