Skip to content

Expect a PSR-18 client instead of a PHP-HTTP client #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2022
Merged

Expect a PSR-18 client instead of a PHP-HTTP client #1110

merged 4 commits into from
Jul 30, 2022

Conversation

JaZo
Copy link
Contributor

@JaZo JaZo commented Jan 20, 2021 •
edited
Loading

Resolves #1076
Requires geocoder-php/provider-integration-tests#18

N.B. It's a chicken and egg problem because in both pull requests the tests will fail because it needs changes from the other PR.

@JaZo JaZo marked this pull request as draft January 20, 2021 08:15
@JaZo
Copy link
Contributor Author

JaZo commented Jan 20, 2021

I can't change the integration tests of the providers because that requires a change in provider-integration-tests, so I'll also create a PR for that and finish this PR after.

@jbelien jbelien requested a review from Nyholm January 20, 2021 08:46
Nyholm
Nyholm reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think this looks good.

I have a few small questions.

@PavelVais
Copy link

Is there any progress of this PR ? It should be done to support guzzle7.

@norkunas
Copy link
Member

norkunas commented Jan 7, 2022

@JaZo are you willing to finish this? :)

@JaZo
Copy link
Contributor Author

JaZo commented Jan 14, 2022

Sorry for the long silence from my end. Yes, I still like to finish this! I'll go ahead and create a PR for provider-integration-tests so I can finish this PR.

@JaZo JaZo mentioned this pull request Jan 14, 2022
Merged
@JaZo
Copy link
Contributor Author

JaZo commented Jan 14, 2022

I've opened geocoder-php/provider-integration-tests#18 for the changes in the integration tests.

@JaZo JaZo marked this pull request as ready for review January 14, 2022 12:20
@jbelien jbelien merged commit 2cf66db into geocoder-php:master Jul 30, 2022
@jbelien jbelien mentioned this pull request Jul 30, 2022
Merged
@jbelien
Copy link
Member

jbelien commented Jul 30, 2022 •
edited
Loading

@JaZo Could you let me know ALL the tags you created ?

You didn't create a tag with the correct semver number for a lot of the tags you created and I need to clean it!

See #1161

@jbelien jbelien mentioned this pull request Jul 30, 2022
Closed
@JaZo JaZo deleted the feature/psr-18 branch August 15, 2022 08:01
@JaZo JaZo mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbelien jbelien jbelien left review comments

@Nyholm Nyholm Nyholm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch from PHP-HTTP to PSR-18

5 participants

@JaZo @PavelVais @norkunas @jbelien @Nyholm