Implement ES256 Sign1 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! Will take a closer look soon. |
geonnave
reviewed
May 20, 2024
| | signature: COSE.Keys.ECDSA.sign(:es256, to_be_signed, private_key) | ||
| } | ||
| end | ||
|
|
There was a problem hiding this comment.
Some of the introduced functions duplicate a fair amount of the body, including sign_encode(:es256 ...), sign(:es256, ...), etc. Could it be improved?
| end | ||
| end | ||
|
|
||
| defmodule COSE.Keys.ECDSA do |
There was a problem hiding this comment.
Any reason for not following defining the key struct here, as in the rest of the library?
| defstruct [:kty, :kid, :alg, :key_ops, :base_iv, :k] | ||
| end | ||
|
|
||
| defmodule ECDSASignature do |
There was a problem hiding this comment.
In case we keep this module (see comment below about struct definition), the name should be COSE.Keys. ECDSASignature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly self explanatory. Includes a test case from the main cose repo.