improve .unique() error message #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunn1313
reviewed
Mar 12, 2025
ianmacartney
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to this PR I opened in the convex-backend repo
Makes the error message thrown by .unique() more useful. Now, the _id's of the first two documents returned by the unique() query are printed in the error message. This is very helpful to the user in identifying and resolving incorrect data.
The wording in the error message has been changed such that it is identical to the error thrown by
.unique()fromconvex-backend(slightly confusing that the same error has different error messages based on where it's thrown from).Feel free to change my wording in the error message - but in my opinion it should be clear that the document id's printed are not all the documents returned by the unique() query but just the first two.
Note: I did not build and test this change locally, and intellisense did not help me in verifying that
_iddoes indeed exist on those objects, so please verify before merging!By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.