Skip to content

Conversation

@markya0616
Copy link

No description provided.

@markya0616 markya0616 force-pushed the feature/gossip_enable branch from d09845a to 19a6ee2 Compare August 7, 2017 08:42
@markya0616 markya0616 force-pushed the feature/gossip_enable branch from 19a6ee2 to 2e6316c Compare August 7, 2017 09:25
@markya0616 markya0616 merged commit 164faea into istanbul/develop Aug 7, 2017
@markya0616 markya0616 deleted the feature/gossip_enable branch August 7, 2017 14:25
yysung1123 pushed a commit that referenced this pull request Oct 24, 2025
## Why this should be merged

Branch-protection rules only require the Go linter (erroneously called
`lint`) by mistake. All linters are now dependencies of a single `lint`
job that remains as a PR gate. New linters will now be enforced by
default.

Closes #138 

## How this works

GitHub Actions `need` configuration. The path limitation of running
`yamllint` is removed because it's such a cheap job so is ok to always
run.

## How this was tested

Inspection of CI run and PR's required jobs:


![image](https://github.com/user-attachments/assets/9454ca35-8a7f-4393-bdd8-5029cfaaf7e6)


![image](https://github.com/user-attachments/assets/e92b964d-5a64-415d-b8a3-1e9c84af3060)
yysung1123 pushed a commit that referenced this pull request Oct 24, 2025
## Why this should be merged

New jobs are easily forgotten in the GitHub rules so we will only gate
on `go` and have all others added as dependencies.

## How this works

Same as #139 

## How this was tested

Inspection of CI run:

![image](https://github.com/user-attachments/assets/f76ce720-a5ed-49e6-b000-265f3660ce8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants