avoid bad block #146
Merged
avoid bad block #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markya0616
force-pushed
the
feature/avoid_bad_block
branch
from
e0e8891 to
8271e4e
Compare
yutelin
approved these changes
Aug 31, 2017
tailingchen
reviewed
Sep 1, 2017
There was a problem hiding this comment.
How about adding hasBadProposal as private method while newRoundState(...)? So that it's no need to pass hasBadProposal function every time.
tailingchen
reviewed
Sep 1, 2017
There was a problem hiding this comment.
I think we can reimplement IsHashLocked . We should check bad block every time.
markya0616
force-pushed
the
feature/avoid_bad_block
branch
2 times, most recently
from
2fd227e to
20f626b
Compare
markya0616
force-pushed
the
feature/avoid_bad_block
branch
from
20f626b to
cd0c67d
Compare
tailingchen
approved these changes
Sep 1, 2017
yysung1123
pushed a commit
that referenced
this pull request
Oct 24, 2025
## Why this should be merged A separately cherry-picked commit, the fix for `StateDB.Copy()`, requires Go 1.23 for use of the `maps` package. This, however, breaks `memsize`, which was later removed later from `geth` for the same reason. ## How this works All release branches will now cherry-pick ethereum#30253. ## How this was tested Updated list of cherry-picks applied to #142, which [passed tests](https://github.com/ava-labs/libevm/actions/runs/13371460014/job/37340683594).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.