Fix context manager allowing to switch to 'No Task' #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could also be adapted to disabling the "set context" button altogether when there's no selected asset or task. Will adapt this PR. |
|
Added the enable/disabled state toggle for the Apply button with 2620c29 Example:
|
|
Great work. Nice and concise. Merge when happy. 👍 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It's possible to have the Context Manager switch the
AVALON_TASKto "No Task" whereas it should disallow that entry to be active task.Reported here
What's changed?
Previously the selected task was retrieved from the view as the
view.currentIndex()however that also allows non-selectable items to be active and returned. Now this is updated to solely using the actually selected rows from the view to ensure the Task is selected and not just the current.This way you cannot switch to the Task, because the "No Task" item is unselectable in the model.