Skip to content

Conversation

@BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Sep 19, 2019

This implements a fix for #454 so that it's visible to the artist which Loader is being used for specific loaded content directly within the Scene Inventory.

This implements solution option 1) as presented in the issue. It's a very minor change in code. :)

BEFORE

before

AFTER

after

@BigRoy BigRoy self-assigned this Sep 19, 2019
@mottosso
Copy link
Contributor

Oo, that is nice. 👍

@davidlatwe
Copy link
Collaborator

What about putting the loader name inside the family column with margin ? Looks like they could be merged together.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Sep 19, 2019

What about putting the loader name inside the family column with margin ? Looks like they could be merged together.

  1. It would complicate the code more than it currently does.
  2. Additionally it disallows sorting either on Family or on Loader type.
  3. It even allows to hide the "Loader" column if you wouldn't care about it and don't want to show it.

It offers less features with more complexity and I personally don't have an issue with it being a column of its own. As such, I personally wouldn't merge the two columns.

@davidlatwe
Copy link
Collaborator

It would complicate the code more than it currently does.

Yeah, good point, just found out that this PR only modified one line. Now I could not bare to complicate it for that, too.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Sep 19, 2019

just found out that this PR only modified one line.

It was definitely more trivial than I expected. 😄

@mkolar
Copy link
Member

mkolar commented Sep 19, 2019

great!

@BigRoy BigRoy merged commit 75e6681 into getavalon:master Sep 20, 2019
@BigRoy BigRoy deleted the fix454 branch January 25, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants