Fix #461: use getfullargspec for Python 3
#462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Nice and simple. Looks good to me.
Be aware that the returned result between getargspec and getfullargspec does vary. However, since it seems we're solely using the first returned index (which is the same for both functions) and you've likely tested this in Python 3 as you described I guess it's fine for our use cases here. Just wanted to highlight this to anyone else seeing this PR.
|
Just to be sure: yes, I did test it :). Because I work mainly with Blender, everything I do is tested in Python 3.7. |
|
Looks good, short and sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #461
What's changed?
Use
inspect.getfullargspecfor Python 3. Also see issue #461.