change fps mapping in maya #475
Conversation
this change is correcting mapping fps values set like decimals. For example fps set as 25.0 wouldn't be mapped correctly. This change will cast fps to int if it finds its decimal places are zero. It is also adding more fps mapping for maya.
avalon/maya/commands.py
Outdated
| '47.952': '47.952fps', | ||
| '47.95': '47.952fps', |
There was a problem hiding this comment.
Just wondering, should both of these values result in the same final FPS? Or is one intended to be the df (Drop Frame) variant? If the latter then it seems the resulting value is wrong?
There was a problem hiding this comment.
Well those are not drop frames, just way to handle rounding. I've sometime noticed that different productions specify framerates with different precision. This handle two and three decimal places as fewer or more doesn't make much sense. This could be handled in more elegant way I suppose but way one can see whats mapped to what.
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Looks good to me. I have never had to use the fractional FPS settings for productions so likely wouldn't use this, but I can see why it could be good for some.
davidlatwe
left a comment
davidlatwe
left a comment
There was a problem hiding this comment.
Sorry for late respond 💦
davidlatwe
left a comment
davidlatwe
left a comment
There was a problem hiding this comment.
Thanks @antirotor ! Good to be merged !
4 participants
What's changed?
Fps in Maya is set by mapping actual fps number to string constants used by Maya to set time units. You can have fps set as integer - 25 or as float 25.0 They are numerically same but mapping recognize only integer. If you pull fps from system like ftrack, where this attribute is set as decimal to allow values like 23.976 it will also returns 25 as 25.0. To handle it, this change cast numbers like 25.0 to integer so mapping still works and adds few other Maya string constants.