Skip to content

fix: pass ~ modifier to location directive #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025
Merged

fix: pass ~ modifier to location directive #689

merged 1 commit into from
Jul 12, 2025

Conversation

amhsirak
Copy link
Member

@amhsirak amhsirak commented Jul 12, 2025

unsure how this got removed, but added it back

Summary by CodeRabbit

  • Chores
    • Updated request matching rules in the server configuration to improve how specific paths and their subpaths are handled. No changes to proxy behavior or headers.

Copy link

coderabbitai bot commented Jul 12, 2025

Walkthrough

The nginx configuration was updated to change the location matching for several API endpoints from a prefix-based match to a regular expression-based match. No changes were made to proxy settings, headers, or any exported or public entities.

Changes

File(s) Change Summary
nginx.conf Changed location directives from prefix (location ^/...) to regex (location ~ ^/...) matching for specific API paths.

Poem

In the warren of configs, a tweak was made,
Prefixes hopped out, regex stayed.
Now nginx listens with sharper ears,
Matching paths with fewer fears.
A gentle shift, a subtle tune—
The server hums a regex rune!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7be3282 and 4fab256.

📒 Files selected for processing (1)
  • nginx.conf (1 hunks)
🔇 Additional comments (1)
nginx.conf (1)

14-14: Critical fix: Restored proper regex matching for API endpoints.

This change correctly adds the ~ modifier to enable regular expression matching. Without this modifier, the location directive was using invalid syntax - the regex pattern ^/(auth|storage|record|workflow|robot|proxy|api-docs|api)(/|$) would be treated as a literal prefix match rather than a regular expression, causing the API proxy to fail.

The fix ensures that requests to /auth, /storage, /record, /workflow, /robot, /proxy, /api-docs, and /api (and their subpaths) are properly proxied to the backend service.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@naveenpan09 naveenpan09 added Type: Bug Something isn't working Scope: Infra All issues/PRs related to infrastructure Scope: Self Host Issues/PRs related to self hosting labels Jul 12, 2025
@naveenpan09 naveenpan09 merged commit b238a52 into develop Jul 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Infra All issues/PRs related to infrastructure Scope: Self Host Issues/PRs related to self hosting Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants